1353: Upgrade flutter 3.19.3 #1355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s as far as possible, update android sdk version since its needed for camera
f1sh1918
commented
Mar 20, 2024
| @@ -770,6 +771,23 @@ | |||
| shellPath = /bin/sh; | |||
| shellScript = "/bin/sh \"$FLUTTER_ROOT/packages/flutter_tools/bin/xcode_backend.sh\" embed_and_thin"; | |||
| }; | |||
| 88929E687A3CA76CCD4D1E20 /* [CP] Copy Pods Resources */ = { | |||
There was a problem hiding this comment.
this was all generated with the update
f1sh1918
commented
Mar 20, 2024
frontend/pubspec.yaml
Outdated
| package_info_plus: ^4.0.1 # for about dialog | ||
| mobile_scanner: 3.1.1 # Pinning this version because of https://github.com/juliansteenbakker/mobile_scanner/issues/582 | ||
| mobile_scanner: ^4.0.1 # Pinning this version because of https://github.com/juliansteenbakker/mobile_scanner/issues/582 |
There was a problem hiding this comment.
this has to be tested properly. in the issue it was mentioned that it should be fixed with XCode 15 and i updated the ios sdk version in another pr, so we should be fine
related #1351
f1sh1918
force-pushed
the
1353-upgrade-flutter-3.19.3
branch
2 times, most recently
from
e0e0ee0 to
03e3e34
Compare
f1sh1918
commented
Mar 25, 2024
f1sh1918
commented
Mar 25, 2024
| @@ -40,7 +40,7 @@ class IdCard extends StatelessWidget { | |||
| aspectRatio: creditCardAspectRatio, | |||
| child: MediaQuery( | |||
| // Ignore text scale factor to enforce the same layout on all devices. | |||
| data: mediaQueryData.copyWith(textScaleFactor: 1), | |||
| data: mediaQueryData.copyWith(textScaler: TextScaler.linear(1)), | |||
There was a problem hiding this comment.
deprecation warning with new flutter version fixed
f1sh1918
force-pushed
the
1353-upgrade-flutter-3.19.3
branch
6 times, most recently
from
ef55105 to
16016f6
Compare
f1sh1918
force-pushed
the
1353-upgrade-flutter-3.19.3
branch
from
16016f6 to
98a5286
Compare
f1sh1918
requested review from
steffenkleinle,
sarahsporck and
ztefanie
as code owners
f1sh1918
commented
Mar 25, 2024
| @@ -1,5 +1,6 @@ | |||
| distributionBase=GRADLE_USER_HOME | |||
| distributionPath=wrapper/dists | |||
| distributionUrl=https\://services.gradle.org/distributions/gradle-7.6-bin.zip | |||
| distributionUrl=https\://services.gradle.org/distributions/gradle-8.4-bin.zip | |||
| networkTimeout=10000 | |||
There was a problem hiding this comment.
was generated by gradle update
f1sh1918
commented
Mar 25, 2024
| @@ -55,7 +55,7 @@ | |||
| # Darwin, MinGW, and NonStop. | |||
| # | |||
| # (3) This script is generated from the Groovy template | |||
| # https://github.com/gradle/gradle/blob/master/subprojects/plugins/src/main/resources/org/gradle/api/internal/plugins/unixStartScript.txt | |||
| # https://github.com/gradle/gradle/blob/HEAD/subprojects/plugins/src/main/resources/org/gradle/api/internal/plugins/unixStartScript.txt | |||
There was a problem hiding this comment.
file generated by gradle update
Co-authored-by: Michael Markl <[email protected]>
ztefanie
approved these changes
Apr 2, 2024
There was a problem hiding this comment.
I guess, this jar file should not be commited?
There was a problem hiding this comment.
it should. this file just changed with gradle update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
Proposed changes
Side effects
Artemissince its discontinued. I didn't face any issues in GraphQL Code generation so far and created an issue for replacing this dev dependency Replace artemis #1352. Please test if Graphql Code generation still works for flutterTested on ios, android and also the ci build for ios and android (you can run commit_main)
Testing
flutter upgradein (/frontend) (dev only)Resolved issues
Fixes: #1285 maybe also fix # 1265 (update of
secure_storage)resolves #1353